Show values that are duplicate in attribute error msg

[PieterCappelle]

When you add values to some attribute it's possible you have created duplicated values. If you want to save that attribute at Stores > Attributes > Products you will see the error messagee "The value of Admin must be unique." but that error message is not telling you which value is not unique.

This PR shows which values are duplicated so you easily update/remove the values so you can pass the error. Let me know if I need to modify something because this is first PR.

Reproduce

1. Create attribute (select)
2. Add values
3. Add value Blue
4. Add second value Blue
5. Submit.

Contribution checklist

• All commits are accompanied by meaningful commit messages
• Pull request has a meaningful description of its purpose
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[omiroshnichenko]

@PieterCappelle Why you can't use msg variable? Why you declare messager function?

[PieterCappelle]

I can't use the msg variable because its not in the scope of the function inside the jQuery.validator.addMethod.

[omiroshnichenko]

@PieterCappelle msg variable declared in the scope of main function at the same scope declared messager function. You can use it.

[PieterCappelle]

@omiroshnichenko No, you will be in a javascript closure - don't know the exact javascript scope name but I think it's a closure - . You have to use custom function to display the msg variable. I tried multiple times like code below and it's not working.

/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

define([
    'jquery',
    'mage/backend/validation'
], function (jQuery) {
    'use strict';

    return function (config) {
        var msg = '',
            _config = jQuery.extend({
                element: null,
                message: '',
                uniqueClass: 'required-unique'
            }, config);

        if (typeof _config.element === 'string') {
            jQuery.validator.addMethod(
                _config.element,

                function (value, element) {
                    var inputs = jQuery(element)
                            .closest('table')
                            .find('.' + _config.uniqueClass + ':visible'),
                        valuesHash = {},
                        isValid = true,
                        duplicates = [];

                    inputs.each(function (el) {
                        var inputValue = inputs[el].value;

                        if (typeof valuesHash[inputValue] !== 'undefined') {
                            isValid = false;
                            duplicates.push(inputValue);
                        }
                        valuesHash[inputValue] = el;
                    });

                    if (!isValid) {
                        msg = _config.message.replace('%1', duplicates.join(', '));
                    }

                    return isValid;
                },

                msg
            );
        }
    };
});

[omiroshnichenko]

@PieterCappelle It would be nice if you will cover this changes with JS tests.

[PieterCappelle]

Do you have any guide to create this, never did this before. Sorry.

[omiroshnichenko]

@PieterCappelle Here is a doc and also you can see in dev/tests/js/jasmine/tests already created tests. If you will have some additional question contact me directly.

[PieterCappelle]

@omiroshnichenko I tried this but it's to complex for me at this moment. I don't even get how I need to make the file structure. Do I need to follow the exact path as in the module directory? Other modules use custom paths and are ignore the path of the module.

[PieterCappelle]

Replied to all your comments @omiroshnichenko. Let me know if I can help.

[Ctucker9233]

@magento-team This PR isn't included in 2.2 Should it be backported?