Skip to content

Refactored settings form #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Refactored settings form #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/com/magento/idea/magento2plugin/project/SettingsForm.form
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<forms/>
</constraints>
<properties>
<text value="Xml configuration"/>
<text value="XML configuration:"/>
</properties>
</component>
<component id="7bde6" class="javax.swing.JLabel">
Expand All @@ -42,7 +42,7 @@
<forms/>
</constraints>
<properties>
<text value="Module Default License Name"/>
<text value="Default license name for new modules:"/>
</properties>
</component>
<component id="87330" class="javax.swing.JTextField" binding="moduleDefaultLicenseName">
Expand All @@ -63,7 +63,7 @@
<forms/>
</constraints>
<properties>
<text value="Magento Installation Path"/>
<text value="Magento installation path:"/>
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the colon here and everywhere. We don't use it for form labels. Thanks

Copy link
Contributor Author

@drpayyne drpayyne Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VitaliyBoyko, thanks for your review. I have made those changes since most of the form labels in default PhpStorm settings uses a colon as shown in the screenshot below. Is there a reason that we're deviating from that design?

Screenshot from 2020-10-20 18-24-34

</properties>
</component>
<component id="99b4d" class="com.intellij.openapi.ui.TextFieldWithBrowseButton" binding="magentoPath">
Expand All @@ -80,7 +80,7 @@
</constraints>
<properties>
<horizontalAlignment value="0"/>
<text value="Regenerate urn map"/>
<text value="Regenerate URN mappings:"/>
</properties>
</component>
<component id="aad3b" class="javax.swing.JTextField" binding="magentoVersion">
Expand All @@ -98,7 +98,7 @@
<forms/>
</constraints>
<properties>
<text value="Magento Version"/>
<text value="Magento version:"/>
</properties>
</component>
</children>
Expand All @@ -109,7 +109,7 @@
</constraints>
<properties>
<selected value="false"/>
<text value="Enable Plugin for this Project"/>
<text value="Enable Magento integration"/>
</properties>
</component>
<component id="47a96" class="javax.swing.JButton" binding="buttonReindex">
Expand All @@ -131,7 +131,7 @@
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="3" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
</constraints>
<properties>
<text value="Enable MFTF Support"/>
<text value="Enable MFTF support"/>
</properties>
</component>
</children>
Expand Down