Skip to content

Conversation

@drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 20, 2020

Description

Refactored labels in the settings form for consistency with other settings forms and grammar.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

</constraints>
<properties>
<text value="Magento Installation Path"/>
<text value="Magento installation path:"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the colon here and everywhere. We don't use it for form labels. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VitaliyBoyko, thanks for your review. I have made those changes since most of the form labels in default PhpStorm settings uses a colon as shown in the screenshot below. Is there a reason that we're deviating from that design?

Screenshot from 2020-10-20 18-24-34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants