Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@dshevtsov
Copy link
Collaborator

Purpose of this pull request

This pull request updates 2.3.4-develop with latest updates from master and resolves all merge conflicts that could no be made by automation.

keharper and others added 30 commits October 8, 2019 15:15
* update deprecated description

* Revert "update deprecated description"

This reverts commit c9b39a0.

* GraphQL: update description of deprecated directive (#5213)

* update deprecated description

* review comments

* MC-19250: The stuck deployment on the Cloud because of consumers (#5289)

* MC-19250: The stuck deployment on the Cloud because of consumers

* Update _includes/config/consumers.md

Co-Authored-By: Margaret Eker <[email protected]>

* GraphQL: Add layered navigation documentation (#5222)

* add filtering example

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* checkpoint

* linting errors

* fix link

* update opening sentence

* remove bogus commit

* Apply suggestions from code review

Co-Authored-By: Erik Marr <[email protected]>

* change code gates

* final review comments

* deprecation notices (#5413)

* review draft (#5426)

* GraphQL: Add fields and example showing cart rule discounts (#5425)

* review draft

* minor tweaks

* review comment

* update example

* MC-18725: Write article with clarification of how to use this functionality

* MC-18725: Write article with clarification of how customer data works

* MC-18725: Write article with clarification of how customer data works

* Small grammar changes.

* GraphQL: Update pricing schema changes (#5512)

* checkpoint

* checkpoint

* minor updates

* review comments

* one more review comment

* more review comments

* correct linting error

* remove stray character from TOC

* Add store name to store config query schema (#5448)

* GraphQL: Add categoryList query (#5562)

* checkpoint

* review draft

* fix linting errors

* add to list of cached queries

* update example to show usage of

* clarify match filters

* Apply suggestions from code review

Added review comments

Co-Authored-By: Jeff Matthews <[email protected]>

* update sample

* rename file

* review comment from Dan

* developer feedback

* resolve more merge conflicts

* linting errors

* linting errors
* GraphQL #932

* GraphQL #933

* GraphQL #942

* GraphQL #942

* GraphQL #901

* GraphQL #895

* GraphQL #895

* GraphQL #951

* review comments

* GraphQL #900
* Resolved issue #5179

* Update guides/v2.2/frontend-dev-guide/themes/theme-create.md

Co-Authored-By: hguthrie <[email protected]>

* Update guides/v2.2/frontend-dev-guide/themes/theme-create.md

Co-Authored-By: hguthrie <[email protected]>

* Update guides/v2.3/frontend-dev-guide/themes/theme-create.md

Co-Authored-By: hguthrie <[email protected]>

* Update guides/v2.3/frontend-dev-guide/themes/theme-create.md

Co-Authored-By: hguthrie <[email protected]>

* Update identity-class.md

* Import the correct `Magento\Framework\GraphQl\Query\Resolver\IdentityInterface`.
* Clarify what is required and what is an implementation detail.

* magento/devdocs#: Add a custom payment method to checkout. Fix Step 4

https://devdocs.magento.com/guides/v2.2/howdoi/checkout/checkout_payment.html
https://devdocs.magento.com/guides/v2.3/howdoi/checkout/checkout_payment.html

* Fixed infobox

* Getting infobox correct

* Trying to fix infobox

* More finessing.

* Debugging

* Pipe in command was breaking infobox formatting

* Escaped pipe in command

* Pipe in command broke formatting.

* Removed pipes from command

* Trailing space.

* trailing space

* trailing space

* MAGETWO-49336: Publication of breaking changes

* Update BICs for 2.2.10

Convert included files to Markdown
Add includes to the topic

* Fix heading id

* MAGETWO-49336: Publication of breaking changes

* Update BICs for 2.3.3

Convert included files to Markdown
Add the includes to main topic

* Fix links (#5690)

* fix links add parans

* remove duplicate topic

* add symlink

* remove duplicate projects topic

* create symlink

* found another problem with a link

* magento/devdocs#: Fix links in How Magento implements indexing (#5656)

https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing.html
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexing.html

* added link to devblog post andfixed broken links in include files

* magento/devdocs#: Describes changeCustomerPassword mutation errors

- https://devdocs.magento.com/guides/v2.3/graphql/mutations/change-customer-password.html

* Markdown linting: Enable rule MD029 (#5698)

* Fixed errors in rest, test, and ui comps

* Fix errors in release notes

* Fixed errors in pattern-library and payment integrations

* Fixed errors in marketplace, migration, mrg, and mtf

* Fixed errors in install, js-dev, and inventory

* Applied peer review edits

* Applied peer review edits

* Removed forced numbering class

* Fixed errors in howdoi

* Fixed errors in get-started, graphql

* Fixed errors in frontend-dev-guide

* Fixed errors in ext-dev

* Fixed some errors in config

* Fixed some errors in config

* Applied edits from peer review

* Removed redundant TOC

* Fixed errors in config

* Fixed errors in coding standards, comp-mgr, contributor

* Disable rule

* Fixed errors in _vidoes, reporting, arch

* Fixed errors in includes (not cloud)

* Enable rule

* Fixed errors in cloud includes

* Fixed errors in cloud

* Added page-builder-types to gitignore file (#5708)

* spaces of course

* move categoryinterface out of category query (#5718)

* Fix syntax for paths to run Actions on

See https://help.github.com/en/articles/workflow-syntax-for-github-actions#example-including-paths
* update example containing bucket in the output

* break out cmsblocks object

* add cms-block

* review comments
* Add content from PR-5685 to develop

* alphabetize field

* review comments
* deprecate attributes

* remove outdated attribute from example
Increment RabbitMQ version support for 2.3.4
* create empty files

* create empty files

* add query/results

* review draft

* remove mergecarts text

* cart_id isn't specific to this query

* fix linting error

* review comments

* more review feedback

* removed extraneous description

* Update guides/v2.3/graphql/queries/customer-cart.md

Co-Authored-By: Erik Marr <[email protected]>
* create empty files

* checkpoint

* checkpoint

* review draft

* fix typo

* found the elusive linting error

* review comment

* Update guides/v2.3/graphql/mutations/merge-carts.md

Co-Authored-By: Erik Marr <[email protected]>

* add links between mutation and query

* Change cart_id to id
Custom layout updates flow has been changed for 2.3.4 and 2.2.11, here's a guide reflecting those changes
@dshevtsov dshevtsov requested a review from keharper December 20, 2019 18:17
@dshevtsov dshevtsov self-assigned this Dec 20, 2019
@dshevtsov dshevtsov changed the title Sync 2.3.4-develop with resolved merge conflicts Sync 2.3.4-develop and resolve merge conflicts Dec 20, 2019
@dshevtsov dshevtsov requested review from a team and jeff-matthews December 20, 2019 18:18
@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov dshevtsov merged commit 1f6b1bb into master Dec 20, 2019
@ghost
Copy link

ghost commented Dec 20, 2019

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov deleted the sync-2.3.4-develop branch December 20, 2019 20:45
jeff-matthews added a commit that referenced this pull request Jan 6, 2020
This reverts commit 1f6b1bb, reversing
changes made to e6475ff.
jeff-matthews added a commit that referenced this pull request Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.