Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@brendanWeb
Copy link

Fixes a grammatical error that could confuse readers.

Fixes a grammatical error that could confuse readers.
@ghost ghost assigned dshevtsov Nov 7, 2016
@tanberry
Copy link

Hi @brendanWeb thanks for your PR. The original sentence is referring to the the list of modules that have dependencies upon the Magento_CatalogStaging module... not the modules upon which the Magento_CatalogStaging module itself depends.

The require section of the composer.json file lists those modules that depend on Magento_CatalogStaging, or "require" the Magento_CatalogStaging module.

Please let us know if this makes sense; it is quite possible that we still have it worded in a confusing way. Thanks again!

@tanberry
Copy link

We are closing the PR, but please do let us know if the wording is still confusing. Thanks!

@tanberry tanberry closed this Dec 22, 2016
magento-cicd2 pushed a commit that referenced this pull request Jun 6, 2017
Updated an example of how to run a test suite
keharper added a commit that referenced this pull request Oct 11, 2019
keharper added a commit that referenced this pull request Oct 11, 2019
keharper added a commit that referenced this pull request Oct 11, 2019
* GraphQL #932

* GraphQL #933

* GraphQL #942

* GraphQL #942

* GraphQL #901

* GraphQL #895

* GraphQL #895

* GraphQL #951

* review comments

* GraphQL #900
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants