This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Small changes #5654
Merged
Small changes #5654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with upstream
as php 7.2 depracted the mcrypt extension the recommendation here should only apply for 7.1. While it is still possible to compile mcrypt for php 7.2 this is not recomandated. Instead, for 7.2 magento the mcrypt_compat php extension is included which supplies the mcrypt functionality.
This page states, that TLS 1.1 is required, but for both paypal and repo.magento.com TLS 1.2 is required. For Paypal, the information is stated here https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements_tls1-2.html For repo.magento.com this ssl test: https://www.ssllabs.com/ssltest/analyze.html?d=repo.magento.com&hideResults=on shows, that TLS 1.2 is required as well.
magento has s upport for nginx as well (see https://devdocs.magento.com/guides/v2.3/install-gde/prereq/nginx.html and https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html so it should be stated here.
hostname can cause an additional delay on each connect depending on your dns setup as the hostname needs to be resolved on each request. Using the IP address should be recommended because of this.
Co-Authored-By: Yaroslav Rogoza <[email protected]>
fix wikipedia url
backport to 2.2
Add the recommendation for using IP address over a hostname for database config
Update required TLS version
Added note about mcrypt and PHP < 7.2
Fix typo in discover-deploy.md
Fix link for U2F Keys
Fixed formatting
Small addition to clarify text
Small corrections to Magento 2.3.3 release notes
fixed MFTF version number
shrielenee
approved these changes
Oct 10, 2019
|
|
||
| 1. Create a `requirejs-config.js` file with the following content: | ||
|
|
||
| ```javascript |
Contributor
There was a problem hiding this comment.
Does this need to be indented to appear correctly?
| | [Google Authenticator](https://support.google.com/accounts/answer/1066447?co=GENIE.Platform%3DAndroid&hl=en) | Generate and enter code from mobile app Requirements: Enable in Admin | `google`| | ||
| | [Authy](https://authy.com/) | SMS, call, token, and one touch <br/>Requirements: Enable in Admin and API keys | `authy` | | ||
| | [U2F Keys](https://docs.magento.com/m2/2.1/ee/user_guide/stores/security-two-factor-authentication-use.html) | Physical device to authenticate, like [YubiKey](https://www.yubico.com/). <br/>Requirements: Enable in Admin | `u2fkey` | | ||
| | [U2F Keys](https://docs.magento.com/m2/ee/user_guide/stores/security-two-factor-authentication-use.html?#u2f-key) | Physical device to authenticate, like [YubiKey](https://www.yubico.com/). <br/>Requirements: Enable in Admin | `u2fkey` | |
Contributor
There was a problem hiding this comment.
I would remove the ?
URL still works without it.
Contributor
Author
|
running tests |
Contributor
Author
|
running tests |
|
Hi @dobooth, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request