Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@snowcore
Copy link
Contributor

@snowcore snowcore commented Oct 5, 2019

Purpose of this pull request

This pull request unifies heading style for KO bindings page (using h3 + code tags)

Affected DevDocs pages

@magento-engcom-team magento-engcom-team added Partner: Mediotype PR created by Mediotype partner partners-contribution PR created by Magento partner labels Oct 5, 2019
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is good to have it all unified

@osrecio osrecio added small changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies and removed Progress: approved labels Oct 8, 2019
@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes labels Oct 8, 2019
@dobooth dobooth changed the base branch from master to small-changes October 8, 2019 15:14
@dobooth dobooth merged commit eb4ea18 into magento:small-changes Oct 8, 2019
@ghost
Copy link

ghost commented Oct 8, 2019

Hi @snowcore, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@snowcore snowcore deleted the fix/ko-bindings-formatting branch October 8, 2019 15:16
@snowcore
Copy link
Contributor Author

snowcore commented Oct 8, 2019

Thanks!

@dobooth dobooth mentioned this pull request Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Mediotype PR created by Mediotype partner partners-contribution PR created by Magento partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants