Skip to content

removed the delete_on_bucket function entirely #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

removed the delete_on_bucket function entirely #85

wants to merge 2 commits into from

Conversation

@lswith
Copy link

@lswith lswith commented Jun 20, 2016 •
edited
Loading

I've signed the CLA and need this feature.

This is not a necessary function and can be safely removed.

@karmi
Copy link

karmi commented Jun 20, 2016

Hi @lswith, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@lswith
Copy link
Author

lswith commented Jun 20, 2016 •
edited
Loading

done.

@joshuaspence
Copy link
Contributor

joshuaspence commented Jun 30, 2016

+1

@ph
Copy link
Contributor

ph commented Aug 24, 2016

LGTM

@elasticsearch-bot
Copy link

elasticsearch-bot commented Aug 24, 2016

Pier-Hugues Pellerin merged this into the following branches!

Branch Commits
master a09b2c7, 6345e42

elasticsearch-bot pushed a commit that referenced this pull request Aug 24, 2016
@ph
removed ruby version
6345e42 
Fixes #85
This was referenced Sep 6, 2016
Closed
Closed
elasticsearch-bot pushed a commit that referenced this pull request Sep 12, 2016
@ph
Delete test files on the remote bucket
afc7e66 
We are reverting the changes we did in #85, if we dont delete the files
the files can polute the bucket. So we will try to delete them and
ignore if it fails. Because in reality we only need the permission to
put an object for this plugin to correctly work.

Fixes: #97

Fixes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lswith @karmi @joshuaspence @ph @elasticsearch-bot