Don't fail catastrophically if delete fails #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is likely not to have DeleteObject permission
|
This is a pretty critical feature. If there is anything I can do to help get this merged please let me know. @rogthefrog FYI, you haven't signed the CLA. |
|
Superseded by #85. |
Contributor
|
@andrewgaul I will do a release really soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment at the top only lists PutObject as the required permission, but the IAM used for this actually needs DeleteObject.
Giving DeleteObject to a logging IAM is often a bad idea in organizations where logs must be immutable and persistent.
This PR:
regionendpoint_regionfrom help text