replace rm_rf instead of rm_rf so we can handled StandardError in the uploading thread

[ph]

replace rm_rf instead of rm_rf so we can handled StandardError in the uploading thread

[ph]

@joshuaspence I've run the integration suite and the normal test, this doesn't affect normal behavior. If a standard error gets raised, it will get logged with the error level.

[elasticsearch-bot]

Pier-Hugues Pellerin merged this into the following branches!

Branch	Commits
master	e5ee0bd

[ph]

Following discussion on #123

[robsonkades]

16:44:27.193 [S3 output uploader, file: C:/logstash-5.2.1/bin/temp/91f5d333-9106-4572-b009-bc22d7f74cad/billing/ls.s3.d1 cab048-b2af-48e2-8941-d348cfb04b35.2018-07-26T16.44.part0.txt.gz] ERROR logstash.outputs.s3 - An error occured in the o
n_completeuploader {:exception=>Errno::EACCES, :message=>"Permission denied - C:/logstash-5.2.1/bin/temp/91f5d333-9106 -4572-b009-bc22d7f74cad/billing/ls.s3.d1cab048-b2af-48e2-8941-d348cfb04b35.2018-07-26T16.44.part0.txt.gz", :path=>"C:/lo gstash-5.2.1/bin/temp/91f5d333-9106-4572-b009-bc22d7f74cad/billing/ls.s3.d1cab048-b2af-48e2-8941-d348cfb04b35.2018-07-26 T16.44.part0.txt.gz", :backtrace=>["org/jruby/RubyFile.java:1129:inunlink'", "C:/logstash-5.2.1/vendor/jruby/lib/ruby/`

logstash v5.2.1