Correctly cleanup file when a S3 upload is succesfully #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TemporaryFile#delete! method was raising an exception because we raryFile#delete! method was raising an exception because we were trying to close a file that was already close, since the on_complete is executed in a thread nothing was present to catch and log that specific error and the thread would just end up getting killed. This PR add guards for closing an already close file, also add test around the stale file uploader checker to make sure only 1 file is remaining on disk after roration. For future debugging purpuse we also log any error that can occur in the uploader callback. Fixes: #122 #120
ph
commented
Jan 18, 2017
| subject.register | ||
| subject.multi_receive_encoded(batch) | ||
| sleep(1) # the periodic check should have kick int | ||
| sleep(5) # the periodic check should have kick in |
Contributor
Author
There was a problem hiding this comment.
give it a bit more time to do his stuff before doing any assert seems to reduce a lot of the noise.
Contributor
|
Should we be using |
Contributor
Author
|
@joshuaspence This is a good point, I will make another PR with
|
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TemporaryFile#delete! method was raising an exception because we
were trying to close a file that was already close, since the
on_completeis executed in a thread nothing was present to catch andlog that specific error and the thread would just end up getting killed.
This PR add guards for closing an already close file, also add test
around the stale file uploader checker to make sure only 1 file is
remaining on disk after rotation.
For future debugging we also log any error that can occur in the
uploader callback.
Fixes: #122 #120