Feat: assert returned item count from _bulk #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we've seen some weird behavior on ES 7.10.2 where a _bulk request to index 69 documents returned 135 entries this leads to an ugly `NoMethodError: undefined method ``[]' for nil:NilClass` resolves logstash-plugins#989
kaisecheng
approved these changes
Mar 4, 2021
Contributor
kaisecheng
left a comment
kaisecheng
left a comment
There was a problem hiding this comment.
LGTM! I left minor feedback on the comment. Feel free to merge
| end | ||
|
|
||
| responses = bulk_response["items"] | ||
| if responses.size != actions.size # can not map action -> response reliably |
Contributor
There was a problem hiding this comment.
could be more explicit in the comment saying
"to deal with weird behavior on ES 7.10.2, 7.11.1 where a _bulk request to
index X documents returned X+Y entries"
kares
added a commit
to kares/logstash-output-elasticsearch
that referenced
this pull request
Mar 4, 2021
* master: Feat: assert returned item count from _bulk (logstash-plugins#997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've seen some weird behavior on ES 7.10.2 (but also with 7.11.1) where a _bulk request to
index 69 documents returned 135 entries
this leads to an ugly
NoMethodError: undefined method ``[]' for nil:NilClassresolves #989