Skip to content

Commit fc7c978

Browse files
committed
Merge branch 'master' into datastreams
* master: Feat: assert returned item count from _bulk (logstash-plugins#997)
2 parents 87e4f26 + 9401759 commit fc7c978

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
- Feat: Data stream support [#988](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/988)
33
- Refactor: unified logging + improvements when ES returns invalid bulk response see [#989](https://github.com/logstash-plugins/logstash-output-elasticsearch/issues/989)
44

5+
## 10.8.5
6+
- Feat: assert returned item count from _bulk [#997](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/997)
7+
58
## 10.8.4
69
- Fixed an issue where a retried request would drop "update" parameters [#800](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/800)
710

lib/logstash/plugin_mixins/elasticsearch/common.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,9 @@ def submit(actions)
232232

233233
responses = bulk_response["items"]
234234
if responses.size != actions.size # can not map action -> response reliably
235+
# an ES bug (on 7.10.2, 7.11.1) where a _bulk request to index X documents would return Y (> X) items
235236
msg = "Sent #{actions.size} documents but Elasticsearch returned #{responses.size} responses"
236-
@logger.debug? && @logger.debug(msg, actions: actions, responses: responses)
237+
@logger.warn(msg, actions: actions, responses: responses)
237238
fail("#{msg} (likely a bug with _bulk endpoint)")
238239
end
239240

0 commit comments

Comments
 (0)