Skip to content

Revert "[libc] exp fuzz tests" #148665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sribee8
Copy link
Contributor

@sribee8 sribee8 commented Jul 14, 2025

Reverts #148086
This broke the build and I'm currently figuring out the problem

@llvmbot llvmbot added the libc label Jul 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 14, 2025

@llvm/pr-subscribers-libc

Author: None (sribee8)

Changes

Reverts llvm/llvm-project#148086
This broke the build and I'm currently figuring out the problem


Full diff: https://github.com/llvm/llvm-project/pull/148665.diff

5 Files Affected:

  • (modified) libc/fuzzing/math/CMakeLists.txt (-36)
  • (removed) libc/fuzzing/math/exp10_fuzz.cpp (-38)
  • (removed) libc/fuzzing/math/exp2_fuzz.cpp (-38)
  • (removed) libc/fuzzing/math/exp_fuzz.cpp (-38)
  • (removed) libc/fuzzing/math/expm1_fuzz.cpp (-38)
diff --git a/libc/fuzzing/math/CMakeLists.txt b/libc/fuzzing/math/CMakeLists.txt
index bf2be5c0b3cea..e3c29651917fc 100644
--- a/libc/fuzzing/math/CMakeLists.txt
+++ b/libc/fuzzing/math/CMakeLists.txt
@@ -62,42 +62,6 @@ add_libc_fuzzer(
     libc.src.math.nextafterl
 )
 
-add_libc_fuzzer(
-  exp_fuzz
-  NEED_MPFR
-  SRCS
-    exp_fuzz.cpp
-  DEPENDS
-    libc.src.math.exp
-)
-
-add_libc_fuzzer(
-  exp10_fuzz
-  NEED_MPFR
-  SRCS
-    exp10_fuzz.cpp
-  DEPENDS
-    libc.src.math.exp10
-)
-
-add_libc_fuzzer(
-  exp2_fuzz
-  NEED_MPFR
-  SRCS
-    exp2_fuzz.cpp
-  DEPENDS
-    libc.src.math.exp2
-)
-
-add_libc_fuzzer(
-  expm1_fuzz
-  NEED_MPFR
-  SRCS
-    expm1_fuzz.cpp
-  DEPENDS
-    libc.src.math.expm1
-)
-
 add_libc_fuzzer(
   asin_fuzz
   NEED_MPFR
diff --git a/libc/fuzzing/math/exp10_fuzz.cpp b/libc/fuzzing/math/exp10_fuzz.cpp
deleted file mode 100644
index 2baef03a264a4..0000000000000
--- a/libc/fuzzing/math/exp10_fuzz.cpp
+++ /dev/null
@@ -1,38 +0,0 @@
-//===-- exp10_fuzz.cpp ----------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// Fuzzing test for llvm-libc exp10 implementation.
-///
-//===----------------------------------------------------------------------===//
-
-#include "src/math/exp10.h"
-#include "utils/MPFRWrapper/mpfr_inc.h"
-#include <math.h>
-
-extern "C" int LLVMFuzzerTestOneInput(double x) {
-  // remove NaN and inf
-  if (isnan(x) || isinf(x))
-    return 0;
-  // signed zeros already tested in unit tests
-  if (signbit(x) && x == 0.0)
-    return 0;
-  mpfr_t input;
-  mpfr_init2(input, 53);
-  mpfr_set_d(input, x, MPFR_RNDN);
-  int output = mpfr_exp10(input, input, MPFR_RNDN);
-  mpfr_subnormalize(input, output, MPFR_RNDN);
-  double to_compare = mpfr_get_d(input, MPFR_RNDN);
-
-  double result = LIBC_NAMESPACE::exp10(x);
-
-  if (result != to_compare)
-    __builtin_trap();
-
-  mpfr_clear(input);
-  return 0;
-}
diff --git a/libc/fuzzing/math/exp2_fuzz.cpp b/libc/fuzzing/math/exp2_fuzz.cpp
deleted file mode 100644
index 8a2959047a6ca..0000000000000
--- a/libc/fuzzing/math/exp2_fuzz.cpp
+++ /dev/null
@@ -1,38 +0,0 @@
-//===-- exp2_fuzz.cpp -----------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// Fuzzing test for llvm-libc exp2 implementation.
-///
-//===----------------------------------------------------------------------===//
-
-#include "src/math/exp2.h"
-#include "utils/MPFRWrapper/mpfr_inc.h"
-#include <math.h>
-
-extern "C" int LLVMFuzzerTestOneInput(double x) {
-  // remove NaN and inf
-  if (isnan(x) || isinf(x))
-    return 0;
-  // signed zeros already tested in unit tests
-  if (signbit(x) && x == 0.0)
-    return 0;
-  mpfr_t input;
-  mpfr_init2(input, 53);
-  mpfr_set_d(input, x, MPFR_RNDN);
-  int output = mpfr_exp2(input, input, MPFR_RNDN);
-  mpfr_subnormalize(input, output, MPFR_RNDN);
-  double to_compare = mpfr_get_d(input, MPFR_RNDN);
-
-  double result = LIBC_NAMESPACE::exp2(x);
-
-  if (result != to_compare)
-    __builtin_trap();
-
-  mpfr_clear(input);
-  return 0;
-}
diff --git a/libc/fuzzing/math/exp_fuzz.cpp b/libc/fuzzing/math/exp_fuzz.cpp
deleted file mode 100644
index 97bc12dfa64c9..0000000000000
--- a/libc/fuzzing/math/exp_fuzz.cpp
+++ /dev/null
@@ -1,38 +0,0 @@
-//===-- exp_fuzz.cpp ------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// Fuzzing test for llvm-libc exp implementation.
-///
-//===----------------------------------------------------------------------===//
-
-#include "src/math/exp.h"
-#include "utils/MPFRWrapper/mpfr_inc.h"
-#include <math.h>
-
-extern "C" int LLVMFuzzerTestOneInput(double x) {
-  // remove NaN and inf
-  if (isnan(x) || isinf(x))
-    return 0;
-  // signed zeros already tested in unit tests
-  if (signbit(x) && x == 0.0)
-    return 0;
-  mpfr_t input;
-  mpfr_init2(input, 53);
-  mpfr_set_d(input, x, MPFR_RNDN);
-  int output = mpfr_exp(input, input, MPFR_RNDN);
-  mpfr_subnormalize(input, output, MPFR_RNDN);
-  double to_compare = mpfr_get_d(input, MPFR_RNDN);
-
-  double result = LIBC_NAMESPACE::exp(x);
-
-  if (result != to_compare)
-    __builtin_trap();
-
-  mpfr_clear(input);
-  return 0;
-}
diff --git a/libc/fuzzing/math/expm1_fuzz.cpp b/libc/fuzzing/math/expm1_fuzz.cpp
deleted file mode 100644
index db507bb02b1d7..0000000000000
--- a/libc/fuzzing/math/expm1_fuzz.cpp
+++ /dev/null
@@ -1,38 +0,0 @@
-//===-- expm1_fuzz.cpp ----------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// Fuzzing test for llvm-libc expm1 implementation.
-///
-//===----------------------------------------------------------------------===//
-
-#include "src/math/expm1.h"
-#include "utils/MPFRWrapper/mpfr_inc.h"
-#include <math.h>
-
-extern "C" int LLVMFuzzerTestOneInput(double x) {
-  // remove NaN and inf
-  if (isnan(x) || isinf(x))
-    return 0;
-  // signed zeros already tested in unit tests
-  if (signbit(x) && x == 0.0)
-    return 0;
-  mpfr_t input;
-  mpfr_init2(input, 53);
-  mpfr_set_d(input, x, MPFR_RNDN);
-  int output = mpfr_expm1(input, input, MPFR_RNDN);
-  mpfr_subnormalize(input, output, MPFR_RNDN);
-  double to_compare = mpfr_get_d(input, MPFR_RNDN);
-
-  double result = LIBC_NAMESPACE::expm1(x);
-
-  if (result != to_compare)
-    __builtin_trap();
-
-  mpfr_clear(input);
-  return 0;
-}

@lntue
Copy link
Contributor

lntue commented Jul 14, 2025

I don't think it's because of your PR: #148091

@sribee8
Copy link
Contributor Author

sribee8 commented Jul 14, 2025

it was not my pr that caused the issue

@sribee8 sribee8 closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants