Skip to content

[opt][timers] Fix time-passes.ll test failing on reversed iterators #131941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025
Merged

[opt][timers] Fix time-passes.ll test failing on reversed iterators #131941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc11984
[opt][timers] Fix time-passes.ll test failing on reversed iterators
alanzhao1 Mar 18, 2025
ca0bd22
fix formatting
alanzhao1 Mar 19, 2025
9004809
remove extra blank lines
alanzhao1 Mar 19, 2025
083c23a
code review comments
alanzhao1 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions llvm/test/Other/time-passes.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,23 @@
; RUN: rm -f %t; opt < %s -disable-output -passes='default<O2>' -time-passes -info-output-file=%t
; RUN: cat %t | FileCheck %s --check-prefix=TIME
;
; TIME: Analysis execution timing report
; TIME: Total Execution Time:
; TIME: Name
; TIME-PER-RUN-DAG: ScalarEvolutionAnalysis
; TIME-PER-RUN-DAG: LoopAnalysis
; TIME-PER-RUN-DAG: DominatorTreeAnalysis
; TIME-PER-RUN-DAG: TargetLibraryAnalysis
; TIME-PER-PASS-DAG: ScalarEvolutionAnalysis
; TIME-PER-PASS-DAG: LoopAnalysis
; TIME-PER-PASS-DAG: DominatorTreeAnalysis
; TIME-PER-PASS-DAG: TargetLibraryAnalysis
; TIME-PER-PASS-NOT: ScalarEvolutionAnalysis #
; TIME-PER-PASS-NOT: LoopAnalysis #
; TIME-PER-PASS-NOT: DominatorTreeAnalysis #
; TIME-PER-PASS-NOT: TargetLibraryAnalysis #
; TIME: Total{{$}}

; TIME: Pass execution timing report
; TIME: Total Execution Time:
; TIME: Name
Expand Down Expand Up @@ -46,23 +63,6 @@
; TIME-PER-PASS-NOT: VerifierPass #
; TIME: Total{{$}}

; TIME: Analysis execution timing report
; TIME: Total Execution Time:
; TIME: Name
; TIME-PER-RUN-DAG: ScalarEvolutionAnalysis
; TIME-PER-RUN-DAG: LoopAnalysis
; TIME-PER-RUN-DAG: DominatorTreeAnalysis
; TIME-PER-RUN-DAG: TargetLibraryAnalysis
; TIME-PER-PASS-DAG: ScalarEvolutionAnalysis
; TIME-PER-PASS-DAG: LoopAnalysis
; TIME-PER-PASS-DAG: DominatorTreeAnalysis
; TIME-PER-PASS-DAG: TargetLibraryAnalysis
; TIME-PER-PASS-NOT: ScalarEvolutionAnalysis #
; TIME-PER-PASS-NOT: LoopAnalysis #
; TIME-PER-PASS-NOT: DominatorTreeAnalysis #
; TIME-PER-PASS-NOT: TargetLibraryAnalysis #
; TIME: Total{{$}}

define i32 @foo() {
%res = add i32 5, 4
br label %loop1
Expand Down
5 changes: 5 additions & 0 deletions llvm/tools/opt/NewPMDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#include "NewPMDriver.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/Statistic.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Analysis/AliasAnalysis.h"
#include "llvm/Analysis/CGSCCPassManager.h"
Expand All @@ -30,6 +31,7 @@
#include "llvm/Passes/PassPlugin.h"
#include "llvm/Passes/StandardInstrumentations.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/Timer.h"
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/VirtualFileSystem.h"
#include "llvm/Support/raw_ostream.h"
Expand Down Expand Up @@ -564,6 +566,9 @@ bool llvm::runPassPipeline(
if (DebugifyEach && !DebugifyExport.empty())
exportDebugifyStats(DebugifyExport, Debugify.getDebugifyStatsMap());

TimerGroup::printAll(*CreateInfoOutputFile());
TimerGroup::clearAll();

return true;
}

Expand Down
Loading