[opt][timers] Fix time-passes.ll test failing on reversed iterators #131941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After llvm#131217 was submitted, time-passes.ll fails because `opt` prints `-time-report` when `ManagedTimerGlobals` is destroyed. `ManagedTimerGlobals` stores `TimerGroup`s in an unordered map, so the ordering of the output `TimerGroup`s depends on the underlying iterator. To fix this, we do what Clang does and use `llvm::TimerGroup::printAll(...)`, which *is* deterministic. This is also what Clang does. This does put move analysis section before the pass section for `-time-report`, but again, this is also what Clang currently does.
aeubanks
reviewed
Mar 19, 2025
Contributor
aeubanks
left a comment
aeubanks
left a comment
There was a problem hiding this comment.
the fact that we have to duplicate printAll/clearAll in multiple places suggests that we should just make ManagedTimerGlobals deterministically destruct its timers. can we do that? somehow sort by name before destructing?
Contributor
Author
This is doable, but I'm not a huge fan of the print metrics on object destruction pattern as it ends up being a painful exercise in object lifetime management rather than something that improves code quality. This is even worse given that this is a global. |
aeubanks
reviewed
Mar 25, 2025
aeubanks
reviewed
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #131217 was submitted, time-passes.ll fails because
optprints-time-reportwhenManagedTimerGlobalsis destroyed.ManagedTimerGlobalsstoresTimerGroups in an unordered map, so the ordering of the outputTimerGroups depends on the underlying iterator.To fix this, we do what Clang does and use
llvm::TimerGroup::printAll(...), which is deterministic. This is also what Clang does. This does put move analysis section before the pass section for-time-report, but again, this is also what Clang currently does.