Skip to content

[MLIR][NFC] Fix comment formatting and use 3 slashes #116201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[MLIR][NFC] Fix comment formatting and use 3 slashes #116201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7dd66c
NFC change making consistent indentation
abdulraheembeigh Nov 14, 2024
42eda8e
NFC- corrected comment syntax
abdulraheembeigh Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ bool isStaticShapeAndContiguousRowMajor(MemRefType type);
/// is also scaled down by `dstBits`/`srcBits`. If `indices` is not provided
/// 0, is returned for the linearized index.
/// - If the size of the load/store is smaller than the linearized memref
/// load/store, the memory region emulated is larger than the actual memory
/// region needed. `intraDataOffset` returns the element offset of the data
/// relevant at the beginning.
/// load/store, the memory region emulated is larger than the actual memory
/// region needed. `intraDataOffset` returns the element offset of the data
/// relevant at the beginning.
struct LinearizedMemRefInfo {
OpFoldResult linearizedOffset;
OpFoldResult linearizedSize;
Expand All @@ -69,8 +69,8 @@ getLinearizedMemRefOffsetAndSize(OpBuilder &builder, Location loc, int srcBits,
int dstBits, OpFoldResult offset,
ArrayRef<OpFoldResult> sizes);

// Track temporary allocations that are never read from. If this is the case
// it means both the allocations and associated stores can be removed.
/// Track temporary allocations that are never read from. If this is the case
/// it means both the allocations and associated stores can be removed.
void eraseDeadAllocAndStores(RewriterBase &rewriter, Operation *parentOp);

/// Given a set of sizes, return the suffix product.
Expand Down Expand Up @@ -106,7 +106,7 @@ computeStridesIRBlock(Location loc, OpBuilder &builder,
/// memory is found (i.e. skip operations that alias the entire view).
MemrefValue skipFullyAliasingOperations(MemrefValue source);

/// Checks if two (memref) values are the same or are statically known to alias
/// Checks if two (memref) values are the same or statically known to alias
/// the same region of memory.
inline bool isSameViewOrTrivialAlias(MemrefValue a, MemrefValue b) {
return skipFullyAliasingOperations(a) == skipFullyAliasingOperations(b);
Expand Down
Loading