Skip to content

Conversation

@abdulraheembeigh
Copy link
Contributor

NFC making a consistent indentation.
Corrected comment syntax. Changed // to ///
and nit grammatical change.

NFC change making consistent indentation.
NFC- corrected comment syntax. Changed // to ///
and nit grammatical change.
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2024

@llvm/pr-subscribers-mlir-memref

@llvm/pr-subscribers-mlir

Author: Abdul Raheem (abdulraheembeigh)

Changes

NFC making a consistent indentation.
Corrected comment syntax. Changed // to ///
and nit grammatical change.


Full diff: https://github.com/llvm/llvm-project/pull/116201.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h (+6-6)
diff --git a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
index a761a77a407e87..34ad279a07a8b5 100644
--- a/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
+++ b/mlir/include/mlir/Dialect/MemRef/Utils/MemRefUtils.h
@@ -44,9 +44,9 @@ bool isStaticShapeAndContiguousRowMajor(MemRefType type);
 ///   is also scaled down by `dstBits`/`srcBits`. If `indices` is not provided
 ///   0, is returned for the linearized index.
 /// - If the size of the load/store is smaller than the linearized memref
-/// load/store, the memory region emulated is larger than the actual memory
-/// region needed. `intraDataOffset` returns the element offset of the data
-/// relevant at the beginning.
+///   load/store, the memory region emulated is larger than the actual memory
+///   region needed. `intraDataOffset` returns the element offset of the data
+///   relevant at the beginning.
 struct LinearizedMemRefInfo {
   OpFoldResult linearizedOffset;
   OpFoldResult linearizedSize;
@@ -69,8 +69,8 @@ getLinearizedMemRefOffsetAndSize(OpBuilder &builder, Location loc, int srcBits,
                                  int dstBits, OpFoldResult offset,
                                  ArrayRef<OpFoldResult> sizes);
 
-// Track temporary allocations that are never read from. If this is the case
-// it means both the allocations and associated stores can be removed.
+/// Track temporary allocations that are never read from. If this is the case
+/// it means both the allocations and associated stores can be removed.
 void eraseDeadAllocAndStores(RewriterBase &rewriter, Operation *parentOp);
 
 /// Given a set of sizes, return the suffix product.
@@ -106,7 +106,7 @@ computeStridesIRBlock(Location loc, OpBuilder &builder,
 /// memory is found (i.e. skip operations that alias the entire view).
 MemrefValue skipFullyAliasingOperations(MemrefValue source);
 
-/// Checks if two (memref) values are the same or are statically known to alias
+/// Checks if two (memref) values are the same or statically known to alias
 /// the same region of memory.
 inline bool isSameViewOrTrivialAlias(MemrefValue a, MemrefValue b) {
   return skipFullyAliasingOperations(a) == skipFullyAliasingOperations(b);

@github-actions
Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@joker-eph joker-eph changed the title NFC sanity changes [MLIR][NFC] Fix comment formatting and use 3 slashes Nov 14, 2024
@joker-eph joker-eph merged commit 8ff2da7 into llvm:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants