[CIR][CodeGen] Replace LLVMIntrinsicCallOp with ACosOp in __builtin_elementwise_acos #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayokunle321
changed the title
FantasqueX
requested changes
Mar 20, 2025
FantasqueX
requested changes
Mar 20, 2025
FantasqueX
reviewed
Mar 20, 2025
FantasqueX
reviewed
Mar 20, 2025
bcardosolopes
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
LGTM pending one minor nit. Thanks for the review @FantasqueX
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
@ayokunle321 please run clang-format before updating the PR |
|
@bcardosolopes done! could I work on atan and asin since they're similar? |
hell yea! |
ayokunle321
changed the title
|
Landed! Thanks for your contribution! @ayokunle321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1374
Replaces LLVMIntrinsicCallOp with ACosOp in __builtin_elementwise_acos.
@bcardosolopes @FantasqueX! If this is all good I was wondering if I could do ASinOp and ATanOp.