Use `ACosOp` instead of `LLVMIntrinsicCallOp` in `__builtin_elementwise_acos`

[FantasqueX]

Just landed it for you over there, let's stay with this one for now, once we rebase next you can update, how about that? Can you file an issue so we don't forget about it?

Originally posted by @bcardosolopes in #1362 (comment)

[ayokunle321]

Hey @FantasqueX! Could I get assigned this? I see that llvm/llvm-project#127317 has been merged.

[shrikardongre]

hey @ayokunle321 are you working on the rebase ? Yesterday i tried to rebase the upstream llvm PR llvm/llvm-project#125748 and ran into some merge conflicts .

[ayokunle321]

@shrikardongre Nope but I'm already working on this issue

[ayokunle321]

Hey @FantasqueX I wanted to see if i was on the right track and also clarify something. Based on the documentation, CIR does not have an ACosOp. In this case, should we directly emit mlir::LLVM::ACosOp without the need for further lowering?

[FantasqueX]

@ayokunle321 Only CIR should be generated in CodeGen stage. You should create a CIR_ACosOp. You can take a look at CIR_ExpOp for reference.

[ayokunle321]

@FantasqueX okay thanks for the clarification! So does creating a CIR_ACosOp all come down to declaring it in CIROps.td like this?

Also do I have to wait for the rebase before making a PR? And, how would I know when you guys do a rebase?

[FantasqueX]

LLVM_ACosOp is in clangir code base currently!

[ayokunle321]

LLVM_ACosOp is in clangir code base currently!

Cool! I'll try and work on it again.