Fix: Server Shutdown Bug #3859
Merged
Fix: Server Shutdown Bug #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ansuman Sahoo <[email protected]>
unsuman
force-pushed
the
fix/ext-driver-shutdown-issue
branch
from
9ddeecb to
62db1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged PR #3836 introduced a 60-second timeout to shut down the gRPC server if no client connects. However, it has a bug: the timer is not cancelled once a client successfully connects. This causes the server to forcefully shut down after 60 seconds, regardless of whether a client has connected.