fix: shutdown server if no client gets connected #3836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
reviewed
Aug 15, 2025
pkg/driver/external/server/server.go
Outdated
Comment on lines
112
to
113
| if err := server.Serve(listener); err != nil { | ||
| logger.Infof("Server stopped: %v", err) |
There was a problem hiding this comment.
Maybe it's better to handle ErrServerStopped separately:
Suggested change
| if err := server.Serve(listener); err != nil { | |
| logger.Infof("Server stopped: %v", err) | |
| if err := server.Serve(listener); err != nil { | |
| if errors.Is(err, grpc.ErrServerStopped) { | |
| logger.Errorf("Server stopped: %v", err) | |
| } else { | |
| logger.Errorf("Failed to serve: %v", err) | |
| } | |
| } |
https://github.com/grpc/grpc-go/blob/e9e00cb28e350d6440145d883d1d6cf675f3c0f3/server.go#L877
Signed-off-by: Ansuman Sahoo <[email protected]>
unsuman
force-pushed
the
fix/ext-driver-shutdown
branch
from
9352aa3 to
8cf209d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3828
Now the server shuts down if no client gets connected within
60s.