Skip to content

itests: add session linking test #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2023
Merged

itests: add session linking test #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5817543
itest: call the rate limit and priv map itest
ellemouton Sep 4, 2023
d0db03a
autopilotserver/mock: upgrade mock for session linking
ellemouton Aug 31, 2023
c56b981
autopilotserver/mock: export RateLimitRule
ellemouton Sep 4, 2023
dd0a7f5
itest: add session linking test
ellemouton Sep 4, 2023
bab43e3
itest: use coop closes instead of force closes
ellemouton Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 43 additions & 4 deletions autopilotserver/mock/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
"sync"

"github.com/btcsuite/btcd/btcec/v2"
"github.com/btcsuite/btcd/btcec/v2/ecdsa"
"github.com/btcsuite/btcd/chaincfg/chainhash"
"github.com/lightninglabs/lightning-terminal/autopilotserverrpc"
"github.com/lightninglabs/lightning-terminal/rules"
"github.com/lightningnetwork/lnd/lntest/node"
Expand Down Expand Up @@ -44,6 +46,7 @@ type ClientState uint8
const (
ClientStateActive = iota
ClientStateInactive
ClientStateRevoked
)

type clientSession struct {
Expand Down Expand Up @@ -103,6 +106,11 @@ func (m *Server) SetFeatures(f map[string]*Feature) {
m.featureSet = f
}

// ResetDefaultFeatures resets the servers features set to the default set.
func (m *Server) ResetDefaultFeatures() {
m.featureSet = defaultFeatures
}

// Terms returns any meta data from the autopilot server.
//
// Note: this is part of the autopilotrpc.AutopilotServer interface.
Expand Down Expand Up @@ -167,6 +175,32 @@ func (m *Server) RegisterSession(_ context.Context,
return nil, err
}

// If linked session, check that signature is valid.
if len(req.GroupResponderKey) != 0 {
// Check that the group key is a known key.
_, ok := m.sessions[hex.EncodeToString(req.GroupResponderKey)]
if !ok {
return nil, fmt.Errorf("unknown group key")
}

// Check that the signature provided is valid.
sig, err := ecdsa.ParseDERSignature(req.GroupResponderSig)
if err != nil {
return nil, err
}

msg := chainhash.HashB(req.ResponderPubKey)

groupKey, err := btcec.ParsePubKey(req.GroupResponderKey)
if err != nil {
return nil, err
}

if !sig.Verify(msg, groupKey) {
return nil, fmt.Errorf("invalid signature")
}
}

m.sessions[hex.EncodeToString(req.ResponderPubKey)] = &clientSession{
key: priv,
state: ClientStateActive,
Expand Down Expand Up @@ -204,7 +238,12 @@ func (m *Server) RevokeSession(_ context.Context,
m.sessMu.Lock()
defer m.sessMu.Unlock()

delete(m.sessions, hex.EncodeToString(req.ResponderPubKey))
sess, ok := m.sessions[hex.EncodeToString(req.ResponderPubKey)]
if !ok {
return nil, nil
}

sess.state = ClientStateRevoked

return &autopilotserverrpc.RevokeSessionResponse{}, nil
}
Expand Down Expand Up @@ -271,7 +310,7 @@ var defaultFeatures = map[string]*Feature{
"HealthCheck": {
Description: "check that your node is up",
Rules: map[string]*RuleRanges{
rules.RateLimitName: rateLimitRule,
rules.RateLimitName: RateLimitRule,
},
Permissions: map[string][]bakery.Op{
"/lnrpc.Lightning/GetInfo": {{
Expand All @@ -283,7 +322,7 @@ var defaultFeatures = map[string]*Feature{
"AutoFees": {
Description: "manages your channel fees",
Rules: map[string]*RuleRanges{
rules.RateLimitName: rateLimitRule,
rules.RateLimitName: RateLimitRule,
},
Permissions: map[string][]bakery.Op{
"/lnrpc.Lightning/ListChannels": {{
Expand All @@ -302,7 +341,7 @@ var defaultFeatures = map[string]*Feature{
},
}

var rateLimitRule = &RuleRanges{
var RateLimitRule = &RuleRanges{
Default: &rules.RateLimit{
WriteLimit: &rules.Rate{
Iterations: 1,
Expand Down
Loading