Skip to content

itests: add session linking test #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2023
Merged

itests: add session linking test #639

merged 5 commits into from
Nov 22, 2023

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented Sep 4, 2023

In this PR, we add a session linking itests which aims to test behaviour across linked sessions. Particularly:

  1. that calls through linked sessions make use of the same privacy mapper
  2. that obfuscated rule values (like channel IDs) use the same privacy mapper across linked sessions
  3. that the rule enforcer uses the same DB across linked sessions

@ellemouton ellemouton force-pushed the sessionLinkingItests branch 4 times, most recently from c49e59c to 0bba526 Compare September 5, 2023 06:46
ViktorT-11
ViktorT-11 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really nice coverage 🔥🚀!!

@lightninglabs-deploy
Copy link

lightninglabs-deploy commented Nov 13, 2023

@bitromortac: review reminder
@ellemouton, remember to re-request review from reviewers when ready

@ellemouton
Copy link
Member Author

ellemouton commented Nov 20, 2023

ping @bitromortac - would be nice to get this in for test coverage 🙏

bitromortac
bitromortac approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great itest! LGTM 🚀

ellemouton
ellemouton commented Nov 22, 2023
View reviewed changes
Copy link
Member Author

@ellemouton ellemouton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks y'all! 🌵

@ellemouton ellemouton merged commit be2a129 into lightninglabs:master Nov 22, 2023
@ellemouton ellemouton deleted the sessionLinkingItests branch November 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorT-11 ViktorT-11 ViktorT-11 approved these changes

@bitromortac bitromortac bitromortac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ellemouton @lightninglabs-deploy @ViktorT-11 @bitromortac