Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR bumps the lightning-terminal version for the wasm-client and mobile to v0.10.5-alpha.

Happy to address any feedback :)!

@ViktorT-11 ViktorT-11 requested a review from jamaljsr August 15, 2023 22:42
@ViktorT-11 ViktorT-11 force-pushed the 2023-08-bump-dependencies branch 2 times, most recently from 0094c09 to 59710a3 Compare August 16, 2023 08:49
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

@levmi levmi requested a review from jbrill August 16, 2023 14:38
@jbrill
Copy link
Contributor

jbrill commented Aug 16, 2023

LGTM!

Bump the lightning-terminal dependency for the wasm-client to
`v0.10.5-alpha`. Also bump lnd to `v0.16.4-beta`, taproot-assets to
`v0.2.3`, loop to `v0.26.2-beta` and grpc to `v1.53.0` as it's required
with the lightning-terminal bump. Also bump the lightning-node-connect
dependency to `v0.2.4-alpha`, but as this dependency is replaced, this
doesn't have any real effect.
Remove the direct dependency on github.com/golang/protobuf and use
google.golang.org/protobuf for mobile instead, as the former is
deprecated.
Bump the lightning-terminal dependency for mobile to `v0.10.5-alpha`.
Also bump lnd to `v0.16.4-beta` and grpc to `v1.53.0` as it's required
with the lightning-terminal bump. Also bump the lightning-node-connect
dependency to `v0.2.4-alpha`, but as this dependency is replaced, this
doesn't have any real effect.
@ViktorT-11 ViktorT-11 force-pushed the 2023-08-bump-dependencies branch from 59710a3 to ae29c6a Compare August 17, 2023 23:17
@ViktorT-11
Copy link
Contributor Author

Thanks for the reviews @jbrill & @guggero 🎉!!

@ellemouton ellemouton merged commit 6cb80bd into lightninglabs:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants