mobile: bump lightning-terminal to v0.10.1-alpha #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorT-11
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Nice catch, my bad! LGTM!
Nit:
If we're updating the go.mod file in the mobile module, it could also be worth replacing the deprecated github.com/golang/protobuf dependency with google.golang.org/protobuf for the mobile module as well, just like we did in aac8c84.
This is no blocker though, so feel free to ignore this if you prefer and we'll do it in the next update instead :)!
|
Closing this as #82 covers this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77 we forgot to bump the
lightning-terminalversion in the mobilego.modfile. This is needed to access the Taproot Assets RPCs from a React native client.