LNC Mobile #52
Merged
LNC Mobile #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
reviewed
Aug 18, 2022
kaloudis
force-pushed
the
lnc-mobile
branch
9 times, most recently
from
2ae7349 to
91cd936
Compare
kaloudis
force-pushed
the
lnc-mobile
branch
from
91cd936 to
af02f7c
Compare
kaloudis
force-pushed
the
lnc-mobile
branch
2 times, most recently
from
e2d993f to
8520d1c
Compare
kaloudis
force-pushed
the
lnc-mobile
branch
7 times, most recently
from
5e47fc1 to
677faaa
Compare
guggero
reviewed
Sep 22, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice work, seems to be pretty straightforward!
Ran into a couple of things, most of them probably easy to fix.
kaloudis
force-pushed
the
lnc-mobile
branch
2 times, most recently
from
f9b1a66 to
835d315
Compare
kaloudis
force-pushed
the
lnc-mobile
branch
3 times, most recently
from
2bb74df to
028fec4
Compare
ellemouton
reviewed
Oct 25, 2022
ellemouton
reviewed
Oct 27, 2022
kaloudis
force-pushed
the
lnc-mobile
branch
3 times, most recently
from
aa762da to
1acfdb0
Compare
ellemouton
reviewed
Oct 27, 2022
kaloudis
force-pushed
the
lnc-mobile
branch
4 times, most recently
from
602342d to
0ef6a51
Compare
ellemouton
approved these changes
Oct 28, 2022
Member
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
Thanks for the fast turn around on review here @kaloudis! Almost there - just a few nits to address and then we are g2g 🚀
mobile/mobile.go
Outdated
| } | ||
|
|
||
| go func() { | ||
| log.Infof("Calling '%s' on RPC with request %s", rpcName, requestJSON) |
Contributor
There was a problem hiding this comment.
You need to set your IDE to use 8 spaces for each tab character. Same for the comment below.
mobile/mobile.go
Outdated
Comment on lines
385
to
395
| return "", fmt.Errorf("macaroon not obtained yet. GetExpiry should " + | ||
| "only be called once the connection is complete") | ||
| } |
ellemouton
reviewed
Oct 28, 2022
mobile/mobile.go
Outdated
| return nil | ||
| }, | ||
| ) | ||
|
|
guggero
approved these changes
Oct 28, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM, pending @ellemouton's comments.
kaloudis
force-pushed
the
lnc-mobile
branch
3 times, most recently
from
0b6eb65 to
4ef1b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native PR: lightninglabs/lnc-rn#2
TODO