mobile: add Mutex for concurrent access of global vars

Author: kaloudis

mobile/mobile.go

@@ -9,6 +9,7 @@ import (
 	"net/http"
 	"regexp"
 	"strings"
+	"sync"
 
 	"github.com/btcsuite/btcd/btcec/v2"
 	"github.com/golang/protobuf/proto"
@@ -90,6 +91,8 @@ var (
 
 	m = make(map[string]*mobileClient)
 
+	mMutex sync.Mutex
+
 	registry = make(map[string]func(context.Context,
 		*grpc.ClientConn, string, func(string, error)))
 
@@ -99,6 +102,9 @@ var (
 // InitLNC sets up everything required for LNC to run including
 // signal interceptor, logs, and an instance of the mobile client.
 func InitLNC(namespace, debugLevel string) error {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	// only initialize interceptor and logs on first connection
 	if !interceptorLogsInitialize {
 		// set debug level to 'info' if not specified
@@ -138,6 +144,9 @@ func InitLNC(namespace, debugLevel string) error {
 func ConnectServer(namespace string, mailboxServer string, isDevServer bool,
 	pairingPhrase string, localStatic string, remoteStatic string) error {
 
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	// Check that the correct arguments and config combinations have been
 	// provided.
 	err := validateArgs(mailboxServer, localStatic, remoteStatic)
@@ -211,11 +220,16 @@ func ConnectServer(namespace string, mailboxServer string, isDevServer bool,
 
 // IsConnected returns whether or not there is an active connection.
 func IsConnected(namespace string) bool {
+	mMutex.Lock()
+	defer mMutex.Unlock()
 	return m[namespace].lndConn != nil
 }
 
 // Disconnect closes the RPC connection.
 func Disconnect(namespace string) {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if m[namespace].lndConn != nil {
 		if err := m[namespace].lndConn.Close(); err != nil {
 			log.Errorf("Error closing RPC connection: %v", err)
@@ -226,6 +240,9 @@ func Disconnect(namespace string) {
 
 // Status returns the status of the LNC RPC connection.
 func Status(namespace string) string {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if m[namespace].statusChecker == nil {
 		return ""
 	}
@@ -236,25 +253,34 @@ func Status(namespace string) string {
 // RegisterLocalPrivCreateCallback sets up the native callbacks upon
 // creation of local private key.
 func RegisterLocalPrivCreateCallback(namespace string, c NativeCallback) {
+	mMutex.Lock()
+	defer mMutex.Unlock()
 	m[namespace].localPrivCreateCallback = c
 }
 
 // RegisterRemoteKeyReceiveCallback sets up the native callbacks upon
 // receiving the remote key from the server.
 func RegisterRemoteKeyReceiveCallback(namespace string, c NativeCallback) {
+	mMutex.Lock()
+	defer mMutex.Unlock()
 	m[namespace].remoteKeyReceiveCallback = c
 }
 
 // RegisterAuthDataCallback sets up the native callbacks upon
 // receiving auth data.
 func RegisterAuthDataCallback(namespace string, c NativeCallback) {
+	mMutex.Lock()
+	defer mMutex.Unlock()
 	m[namespace].authDataCallback = c
 }
 
 // InvokeRPC makes a synchronous RPC call.
 func InvokeRPC(namespace string, rpcName string, requestJSON string,
 	c NativeCallback) error {
 
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if rpcName == "" {
 		return fmt.Errorf("param rpcName required")
 	}
@@ -291,6 +317,9 @@ func InvokeRPC(namespace string, rpcName string, requestJSON string,
 
 // GetExpiry returns the expiration time of the connection macaroon.
 func GetExpiry(namespace string) (string, error) {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if m[namespace].mac == nil {
 		return "", fmt.Errorf("macaroon not obtained yet. GetExpiry should " +
 			"only be called once the connection is complete")
@@ -306,6 +335,9 @@ func GetExpiry(namespace string) (string, error) {
 
 // IsReadOnly returns whether or not the connection macaroon is read-only.
 func IsReadOnly(namespace string) bool {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if m[namespace].mac == nil {
 		log.Errorf("macaroon not obtained yet. IsReadOnly should " +
 			"only be called once the connection is complete")
@@ -326,6 +358,9 @@ func IsReadOnly(namespace string) bool {
 // HasPermissions returns whether or not the connection macaroon
 // has a specificed permission.
 func HasPermissions(namespace, permission string) bool {
+	mMutex.Lock()
+	defer mMutex.Unlock()
+
 	if permission == "" {
 		return false
 	}