Skip to content

Bump MSRV to rustc 1.85 #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Bump MSRV to rustc 1.85 #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
toolchain: [
stable,
beta,
1.75.0, # Our MSRV
1.85.0, # Our MSRV
Copy link
Contributor

@jkczyz jkczyz Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?

Copy link
Collaborator Author

@tnull tnull Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).

]
include:
- toolchain: stable
Expand All @@ -29,7 +29,7 @@ jobs:
platform: macos-latest
- toolchain: stable
platform: windows-latest
- toolchain: 1.75.0
- toolchain: 1.85.0
msrv: true
runs-on: ${{ matrix.platform }}
steps:
Expand All @@ -42,11 +42,6 @@ jobs:
- name: Check formatting on Rust ${{ matrix.toolchain }}
if: matrix.check-fmt
run: rustup component add rustfmt && cargo fmt --all -- --check
- name: Pin packages to allow for MSRV
if: matrix.msrv
run: |
cargo update -p home --precise "0.5.9" --verbose # home v0.5.11 requires rustc 1.81 or newer
cargo update -p idna_adapter --precise "1.1.0" --verbose # idna_adapter 1.2 switched to ICU4X, requiring 1.81 and newer
- name: Set RUSTFLAGS to deny warnings
if: "matrix.toolchain == 'stable'"
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
Expand Down Expand Up @@ -79,7 +74,7 @@ jobs:
if: matrix.build-uniffi
run: cargo build --features uniffi --verbose --color always
- name: Build documentation on Rust ${{ matrix.toolchain }}
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.75.0'"
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.85.0'"
run: |
cargo doc --release --verbose --color always
cargo doc --document-private-items --verbose --color always
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ LDK Node currently comes with a decidedly opinionated set of design choices:
LDK Node itself is written in [Rust][rust] and may therefore be natively added as a library dependency to any `std` Rust program. However, beyond its Rust API it also offers language bindings for [Swift][swift], [Kotlin][kotlin], and [Python][python] based on the [UniFFI](https://github.com/mozilla/uniffi-rs/). Moreover, [Flutter bindings][flutter_bindings] are also available.

## MSRV
The Minimum Supported Rust Version (MSRV) is currently 1.75.0.
The Minimum Supported Rust Version (MSRV) is currently 1.85.0.

[api_docs]: https://docs.rs/ldk-node/*/ldk_node/
[api_docs_node]: https://docs.rs/ldk-node/*/ldk_node/struct.Node.html
Expand Down
Loading