Bump MSRV to rustc 1.85 #606
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
.github/workflows/rust.yml
Outdated
| # - name: Pin packages to allow for MSRV | ||
| # if: matrix.msrv | ||
| # run: |
There was a problem hiding this comment.
We could, I mainly left it in because I expect that some dependencies will require pinning again soon. Now dropped it.
| stable, | ||
| beta, | ||
| 1.75.0, # Our MSRV | ||
| 1.85.0, # Our MSRV |
There was a problem hiding this comment.
Given we were already at 1.75.0, I take it is ok that we are ahead of rust-bitcoin and rust-lightning? IIRC, those used 1.63.0 as the MSRV. We're we just ahead back we had some other dependency that required a higher MSRV?
There was a problem hiding this comment.
Yes, it's mostly the HTTP stack depedencies that had us at 1.75. However, I generally like the concept of following Debian stable rustc (which it's pretty conservative).
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the `main` branch here.
tnull
force-pushed
the
2025-08-bump-msrv-to-1.85
branch
from
f7a29f4 to
1af27ac
Compare
|
Also rebased to fix CI. |
3 participants
We generally align our MSRV with Debian's stable channel. Debian 13 'Trixie' was just released, shipping rustc 1.85. We therefore bump our MSRV on the
mainbranch here.