Fixing variant retrieving when toggle is off #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This LGTM-- we'll do some testing on the branch via our integration harness and merge to master if it passes. Thanks for the PR! |
Contributor
|
Merging into a non-master branch so we can test internally. |
Contributor
|
Tests passed! Thanks for the PR! |
Author
|
Thanks a lot! 😉 👍 |
Author
|
@drichelson hey, thanks for this, but we checked and the changes didn't get applied to the 2.0.2 version, was there a problem? 😄 |
Contributor
|
Sorry about that @Rheed ! we just released 2.0.3 which contains your changes |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Apr 24, 2020
ensure events aren't sent if send_events is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now it didn't change if you had your toggle Off or On with false, as both options where returning null when asking for the variant value. It happens that null is not exactly the same as false, this fixes it and now properly returns a false when it's false. This problem also happened when any of your multivariant values was a false too
Hope we can fix this, as we need it for properly A/B testing 😄