Merge pull request #52 from launchdarkly/eb/ch74871/dont-send-events

ensure events aren't sent if send_events is false

Author: eli-darkly

src/LaunchDarkly/LDClient.php

@@ -2,7 +2,7 @@
 namespace LaunchDarkly;
 
 use LaunchDarkly\Impl\EventFactory;
-use LaunchDarkly\Impl\NullEventPublisher;
+use LaunchDarkly\Impl\NullEventProcessor;
 use LaunchDarkly\Integrations\Guzzle;
 use Monolog\Handler\ErrorLogHandler;
 use Monolog\Logger;
@@ -129,7 +129,7 @@ public function __construct($sdkKey, $options = array())
             }
             $this->_eventProcessor = $ep;
         } elseif ($this->_offline || !$this->_send_events) {
-            $this->_eventProcessor = new EventProcessor($sdkKey, $options);
+            $this->_eventProcessor = new NullEventProcessor($sdkKey, $options);
         } else {
             $this->_eventProcessor = new EventProcessor($sdkKey, $options);
         }

tests/LDClientTest.php

@@ -593,6 +593,22 @@ public function testTrackSendsEventWithDataAndMetricValue()
         $this->assertEquals($metricValue, $event['metricValue']);
     }
 
+    public function testEventsAreNotPublishedIfSendEventsIsFalse()
+    {
+        // In order to do this test, we cannot provide a mock object for Event_Processor_,
+        // because if we do that, it won't bother even looking at the send_events flag.
+        // Instead, we need to just put in a mock Event_Publisher_, so that the default
+        // EventProcessor would forward events to it if send_events were not disabled.
+        $mockPublisher = new MockEventPublisher("", array());
+        $options = array(
+            'feature_requester_class' => MockFeatureRequester::class,
+            'event_publisher' => $mockPublisher
+        );
+        $client = new LDClient("someKey", $options);
+        $client->track('eventkey', new LDUser('userkey'));
+        $this->assertEquals(array(), $mockPublisher->payloads);
+    }
+
     public function testOnlyValidFeatureRequester()
     {
         $this->setExpectedException(InvalidArgumentException::class);

tests/MockEventPublisher.php

@@ -0,0 +1,16 @@
+<?php
+namespace LaunchDarkly\Tests;
+
+class MockEventPublisher implements \LaunchDarkly\EventPublisher
+{
+    public $payloads = array();
+
+    public function __construct($sdkKey, array $options)
+    {
+    }
+
+    public function publish($payload)
+    {
+        $this->payloads[] = $payload;
+    }
+}