Check feature requester passed in options has the required interface #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should pass CI after merging master back into this branch. |
|
@richardmiller would you mind merging back master and updating this PR? That should make it fairly trivial to merge this. |
richardmiller-zz
force-pushed
the
check-feature-requester-interface
branch
from
dd88eba to
87ec45c
Compare
Conflicts: composer.lock Conflicts: composer.lock
richardmiller-zz
force-pushed
the
check-feature-requester-interface
branch
from
87ec45c to
3349a3b
Compare
|
@jkodumal got there in the end :) Had to downgrade phpunit back to 4.8 as version 5 onwards requires php >= 5.6 |
|
Thanks! LGTM. |
eli-darkly
added a commit
that referenced
this pull request
Aug 25, 2018
add ability to filter for client-side flags only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.