Check that FeatureRequester class in options is valid

Author: richardmiller-zz

src/LaunchDarkly/LDClient.php

@@ -64,6 +64,10 @@ public function __construct($apiKey, $options = array()) {
         } else {
             $featureRequesterClass = '\\LaunchDarkly\\GuzzleFeatureRequester';
         }
+
+        if (!is_a($featureRequesterClass, FeatureRequester::class, true)) {
+            throw new \InvalidArgumentException;
+        }
         $this->_featureRequester = new $featureRequesterClass($this->_baseUri, $apiKey, $options);
     }
 

tests/LDClientTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace LaunchDarkly\Tests;
 
+use InvalidArgumentException;
 use LaunchDarkly\FeatureRequester;
 use LaunchDarkly\LDClient;
 use LaunchDarkly\LDUserBuilder;
@@ -66,6 +67,11 @@ public function testToggleEventsOff() {
         $queue = getPrivateField($proc, '_queue');
         $this->assertEquals(0, sizeof($queue));
     }
+
+    public function testOnlyValidFeatureRequester() {
+        $this->expectException(InvalidArgumentException::class);
+        new LDClient("BOGUS_API_KEY", ['feature_requester_class' => 'stdClass']);
+    }
 }