-
Notifications
You must be signed in to change notification settings - Fork 94
feat: DO NOT REVIEW CI TEST : not multithread safe access to cancel var #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abelonogov-ld
wants to merge
10
commits into
v9
Choose a base branch
from
andrey/ci-issues
base: v9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3184f84
fix: not multithread safe access to cancel var
abelonogov-ld 9f4d149
Revert "fix: not multithread safe access to cancel var"
abelonogov-ld fd187ab
fix for unit test (+2 squashed commits)
abelonogov-ld ba72c4c
just using TimeoutExecutor
abelonogov-ld 7a2e5ff
clean up old code
abelonogov-ld ceb598a
reverse LDClientSpec
abelonogov-ld 73524ab
fixed xcode project
abelonogov-ld dce19d0
fix project
abelonogov-ld c83a40e
Add unit tests
abelonogov-ld 6b46383
UTF-8 encoding in project file
abelonogov-ld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
LaunchDarkly/LaunchDarkly/ServiceObjects/TimeoutExecutor.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import Foundation | ||
|
|
||
| /// A lightweight utility for executing asynchronous operations with a timeout fallback. | ||
| /// | ||
| /// `TimeoutExecutor` guarantees that the provided `completion` closure is called **exactly once**, | ||
| /// either with the result of the asynchronous operation or with a timeout value if the operation | ||
| /// does not complete in time. | ||
| /// | ||
| /// ### Typical Usage | ||
| /// ```swift | ||
| /// TimeoutExecutor.run( | ||
| /// timeout: 2.0, | ||
| /// queue: .main, | ||
| /// operation: { done in | ||
| /// service.action() { | ||
| /// done("Success") | ||
| /// } | ||
| /// }, | ||
| /// timeoutValue: "Timeout", | ||
| /// completion: { result in | ||
| /// print("Result:", result) | ||
| /// } | ||
| /// ) | ||
| /// ``` | ||
| /// | ||
| final class TimeoutExecutor { | ||
| private init() {} | ||
|
|
||
| static func run<T>( | ||
| timeout: TimeInterval, | ||
| queue: DispatchQueue = .global(), | ||
| operation: (@escaping (T) -> Void) -> Void, | ||
| timeoutValue: @autoclosure @escaping () -> T, | ||
| completion: ((T) -> Void)? | ||
| ) { | ||
| guard let completion = completion else { | ||
| operation { _ in | ||
| /* ignore result */ | ||
| } | ||
| return | ||
| } | ||
|
|
||
| let lockQueue = DispatchQueue(label: "launchdarkly.timeout.executor.lock") | ||
| var finished = false | ||
|
|
||
| // Start the user operation | ||
| operation { value in | ||
| var shouldCall = false | ||
| lockQueue.sync { | ||
| if !finished { | ||
| finished = true | ||
| shouldCall = true | ||
| } | ||
| } | ||
|
|
||
| if shouldCall { | ||
| queue.async { completion(value) } | ||
| } | ||
| } | ||
|
|
||
| // Timeout fallback | ||
| queue.asyncAfter(deadline: .now() + timeout) { | ||
| var shouldCall = false | ||
| lockQueue.sync { | ||
| if !finished { | ||
| finished = true | ||
| shouldCall = true | ||
| } | ||
| } | ||
|
|
||
| if shouldCall { | ||
| completion(timeoutValue()) | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Callback Context Inconsistency
The
startmethod's completion callback has an inconsistent execution context. Whenconfig.startOnlineis false, the callback runs on the current thread, but when true, it's dispatched tointernalCompletedQueue. This difference in threading might lead to unexpected behavior for callers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, but this is not part of this fix