Skip to content

Conversation

@abelonogov-ld
Copy link

@abelonogov-ld abelonogov-ld commented Oct 15, 2025

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.


Note

Introduce TimeoutExecutor to manage async operations with timeouts and refactor LDClient.identify and LDClient.start to use it; add unit tests.

  • Core:
    • Utility: Add ServiceObjects/TimeoutExecutor.swift to run async operations with a timeout, ensuring single completion on a specified DispatchQueue.
    • LDClient:
      • Refactor identify(context:timeout:useCache:completion:) to use TimeoutExecutor instead of manual cancel flags.
      • Refactor timed-start path start(..., startWaitSeconds:, ...) to use TimeoutExecutor for timeout handling.
  • Tests:
    • Add LaunchDarklyTests/ServiceObjects/TimeoutExecutorSpec.swift covering result-before-timeout, timeout fallback, race, specified-queue execution, no-completion behavior, and late-result ignored.
  • Project:
    • Wire new sources and tests into build targets.

Written by Cursor Bugbot for commit 6b46383. This will update automatically on new commits. Configure here.

@abelonogov-ld abelonogov-ld requested a review from a team as a code owner October 15, 2025 16:48
@abelonogov-ld abelonogov-ld changed the title TEST DO NOT REVIEW fix: not multithread safe access to cancel var DO NOT REVIEW CI TEST : not multithread safe access to cancel var Oct 15, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@abelonogov-ld abelonogov-ld changed the title DO NOT REVIEW CI TEST : not multithread safe access to cancel var feat: DO NOT REVIEW CI TEST : not multithread safe access to cancel var Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants