Skip to content

Conversation

Copy link

Copilot AI commented Nov 2, 2025

Addresses apache#452 (comment)

The internal constant ReferenceMetadata.REFERENCE_NAME_SATISFYING_CONDITION was a temporary placeholder meant to be replaced with the official OSGi R8 spec constant once available.

Changes

  • Removed internal constant definition and javadoc from ReferenceMetadata
  • Replaced all usages with ComponentConstants.REFERENCE_NAME_SATISFYING_CONDITION from org.osgi.service.component (version 1.5.0, already a dependency)
  • Updated imports in:
    • XmlHandler.java (3 usages)
    • DependencyManager.java (1 usage)
    • SatisfyingConditionComponentClass.java (1 test usage)

Net change: -5 lines across 4 files.

Original prompt

Please resolve comment from user on this PR apache#452 (comment)

we should remove the internal constant and javadoc and replace it with the official one referenced in the comment:

The point of this comment wasn't to add javadoc later to this internal class. It was to remind us to use the actual spec'ed constant from the released APIs
https://github.com/osgi/osgi/blob/eb08fcac898f50aec1a1d2847cae6ffccd5a7385/org.osgi.service.component/src/org/osgi/service/component/ComponentConstants.java#L161


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove internal constant and replace with official constant Replace internal REFERENCE_NAME_SATISFYING_CONDITION with OSGi spec constant Nov 2, 2025
Copilot AI requested a review from laeubi November 2, 2025 16:24
Copilot finished work on behalf of laeubi November 2, 2025 16:24
@laeubi laeubi marked this pull request as ready for review November 2, 2025 16:25
@laeubi laeubi merged commit 76e900d into master Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants