Adjust Codebase to already released R8 spec compliance #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
fixup_r8_compliance
branch
from
6061636 to
6c32c2c
Compare
Author
|
Thanks @stbischof |
tjwatson
reviewed
Nov 2, 2025
| * The reference name for the implicit satisfying condition as defined in the | ||
| * OSGi R8 Declarative Services specification (see https://github.com/osgi/osgi/pull/875). | ||
| * This reference is automatically added to components when a true condition service is available. | ||
| */ |
Member
There was a problem hiding this comment.
The point of this comment wasn't to add javadoc later to this internal class. It was to remind us to use the actual spec'ed constant from the released APIs
https://github.com/osgi/osgi/blob/eb08fcac898f50aec1a1d2847cae6ffccd5a7385/org.osgi.service.component/src/org/osgi/service/component/ComponentConstants.java#L161
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Felix code mentions a R8 feature (satisfying condition) as a TODO, but as R8 is out already this seems no longer needed.
Changes
osgi.ds.satisfying.condition.targetproperty