Skip to content

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 23, 2025

What this PR does / why we need it:
Thx @Karthik-K-N @JoelSpeed for implementing the linter!

Corresponding finding was fixed a while back via: #12452

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2025
@sbueringer
Copy link
Member Author

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci and removed do-not-merge/needs-area PR is missing an area label labels Jul 23, 2025
@sbueringer
Copy link
Member Author

Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thank you, I was about to do this, but got this notification.

@JoelSpeed
Copy link
Contributor

/approve

Just needs that comment fixing up and good to go

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@sbueringer sbueringer force-pushed the pr-bump-kal-add-notimestamps branch from 030a33f to 114837a Compare July 23, 2025 17:04
@sbueringer
Copy link
Member Author

Done

@Karthik-K-N
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cffd6ccbf44e0321fac5dc39eaf005fdeffe5f44

@k8s-ci-robot k8s-ci-robot merged commit 9acc8fe into kubernetes-sigs:main Jul 23, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 23, 2025
@sbueringer sbueringer deleted the pr-bump-kal-add-notimestamps branch July 23, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants