Skip to content

⚠️ Rename LastRemediationStatus.Timestamp to Time in KCP #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

⚠️ Rename LastRemediationStatus.Timestamp to Time in KCP #12452

merged 1 commit into from
Jul 9, 2025

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 7, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2025
@sbueringer sbueringer mentioned this pull request Jul 7, 2025
Closed
62 tasks
@sbueringer sbueringer changed the title ⚠️ Rename LastRemediationStatus.Timestamp to LastRemediationStatus.Time in KCP ⚠️ Rename LastRemediationStatus.Timestamp to Time in KCP Jul 7, 2025
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 7, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @JoelSpeed @sivchari
/cc @Karthik-K-N

@k8s-ci-robot k8s-ci-robot requested a review from Karthik-K-N July 7, 2025 09:56
@sbueringer sbueringer force-pushed the pr-kcp-time-rename branch from 65e6a6f to 72414ad Compare July 7, 2025 09:58
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

sivchari
sivchari reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1af9215b2a799d71c3fc93af8ab2c7a5a63edecf

@sbueringer
Copy link
Member Author

sbueringer commented Jul 7, 2025 •
edited
Loading

Not sure why my local conversion-gen generated something different (probably had an old version), will push a fix in a bit

@sbueringer sbueringer force-pushed the pr-kcp-time-rename branch from 72414ad to 6e39502 Compare July 7, 2025 10:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

JoelSpeed
JoelSpeed reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 858e970c688f06eb267615e475dc9e44581f22fd

@sbueringer sbueringer force-pushed the pr-kcp-time-rename branch from 6e39502 to 5923445 Compare July 7, 2025 12:27
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@sbueringer
Copy link
Member Author

Sorry, forgot to regenerate conversion after implementing it. Pushed a fix

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-kcp-time-rename branch from 5923445 to 2e7b335 Compare July 7, 2025 14:04
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

Expected flake + another failure. I think that's also a flake but let's see

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 8, 2025 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 2e7b335 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/override pull-cluster-api-e2e-main

Only the expected flake now

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

/override pull-cluster-api-e2e-main

Only the expected flake now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mboersma
mboersma approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for maintainer re-review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5abe68ac6aede0e658deb8049f92579da0f0bc31

sivchari
sivchari reviewed Jul 9, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@JoelSpeed
Copy link
Contributor

@sbueringer I'm happy to merge if you are, feel free to remove the hold

@sbueringer
Copy link
Member Author

Yeah. Let's merge. Fabrizio can review once he's back and I can follow-up if necessary, but this seems like a straightforward change (I also talked to him about it before and we agreed that we want to make the change).

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7411836 into kubernetes-sigs:main Jul 9, 2025
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 9, 2025
@sbueringer sbueringer deleted the pr-kcp-time-rename branch July 9, 2025 12:26
@sbueringer sbueringer mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@g-gaston g-gaston Awaiting requested review from g-gaston

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

2 more reviewers

@sivchari sivchari sivchari left review comments

@mboersma mboersma mboersma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mboersma mboersma

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

@Karthik-K-N Karthik-K-N

@sivchari sivchari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

7 participants

@sbueringer @k8s-ci-robot @JoelSpeed @mboersma @Karthik-K-N @sivchari @fabriziopandini