-
Notifications
You must be signed in to change notification settings - Fork 54
feat(ws): Notebooks 2.0 // Backend // Add tests to repositories/namespaces #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roee1313
wants to merge
1
commit into
kubeflow:notebooks-v2
Choose a base branch
from
roee1313:test_coverage_roee
base: notebooks-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
workspaces/backend/internal/repositories/namespaces/repo_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
/* | ||
Copyright 2024. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package namespaces | ||
|
||
import ( | ||
"context" | ||
"errors" | ||
"testing" | ||
|
||
. "github.com/onsi/ginkgo/v2" | ||
. "github.com/onsi/gomega" | ||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
"sigs.k8s.io/controller-runtime/pkg/client" | ||
"sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
) | ||
|
||
func TestNamespaceRepository(t *testing.T) { | ||
RegisterFailHandler(Fail) | ||
RunSpecs(t, "NamespaceRepository Suite") | ||
} | ||
|
||
var _ = Describe("Namespaces", Ordered, func() { | ||
var ( | ||
scheme *runtime.Scheme | ||
fakeClient client.Client | ||
namespaceRepo *NamespaceRepository | ||
ctx context.Context | ||
) | ||
BeforeAll(func() { | ||
ctx = context.Background() | ||
scheme = runtime.NewScheme() | ||
Expect(corev1.AddToScheme(scheme)).To(Succeed()) | ||
}) | ||
Context("with no existing Namespaces", func() { | ||
BeforeEach(func() { | ||
fakeClient = fake.NewClientBuilder().WithScheme(scheme).Build() | ||
namespaceRepo = NewNamespaceRepository(fakeClient) | ||
|
||
}) | ||
It("should return an empty list of Namespaces", func() { | ||
namespaces, err := namespaceRepo.GetNamespaces(ctx) | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(namespaces).To(BeEmpty()) | ||
}) | ||
}) | ||
Context("with existing Namespaces", func() { | ||
BeforeEach(func() { | ||
ns1 := &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: "test-ns-1"}} | ||
ns2 := &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: "test-ns-2"}} | ||
|
||
fakeClient = fake.NewClientBuilder().WithScheme(scheme).WithObjects(ns1, ns2).Build() | ||
namespaceRepo = NewNamespaceRepository(fakeClient) | ||
|
||
}) | ||
It("should return all namespaces", func() { | ||
namespaces, err := namespaceRepo.GetNamespaces(ctx) | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(namespaces).To(HaveLen(2)) | ||
Expect(namespaces[0].Name).To(Equal("test-ns-1")) | ||
Expect(namespaces[1].Name).To(Equal("test-ns-2")) | ||
}) | ||
}) | ||
Context("when client.List returns an error", func() { | ||
BeforeEach(func() { | ||
fakeClient := fake.NewClientBuilder().WithScheme(scheme).Build() | ||
errorClient := &erroringClient{Client: fakeClient} | ||
namespaceRepo = NewNamespaceRepository(errorClient) | ||
}) | ||
|
||
It("should return an error", func() { | ||
namespaces, err := namespaceRepo.GetNamespaces(ctx) | ||
Expect(err).To(HaveOccurred()) | ||
var mockErr *MockError | ||
Expect(errors.As(err, &mockErr)).To(BeTrue()) | ||
Expect(namespaces).To(BeNil()) | ||
}) | ||
}) | ||
}) | ||
|
||
// Define a wrapper client that forces an error on List() method of client | ||
type erroringClient struct { | ||
client.Client | ||
} | ||
|
||
type MockError struct { | ||
message string | ||
} | ||
|
||
func (e *MockError) Error() string { | ||
return e.message | ||
} | ||
|
||
func (e *erroringClient) List(ctx context.Context, list client.ObjectList, opts ...client.ListOption) error { | ||
return &MockError{message: "mocked list error"} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice to call out in PR description that this dependency is brought in as part of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, will learn for next time :)
Thanks!