feat(ws): Notebooks 2.0 // Backend // Add tests to repositories/namespaces

[roee1313]

this PR adds a test file to workspaces/backend/internal/repositories/namespaces/repo.go
Partially solves issue #381

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyatmiami]

might be nice to call out in PR description that this dependency is brought in as part of:

• "sigs.k8s.io/controller-runtime/pkg/client/fake"

[roee1313]

got it, will learn for next time :)
Thanks!

[andyatmiami]

I typically avoid the "magic strings" assertion pattern where we rely on setting an error string.. and then asserting on that error string in the test itself... its too brittle (when the values are hard-coded like this)... even declaring an additional var I don't like...

For your consideration - how do you feel about something like this?

type MockError struct {
    message string
}

func (e *MockError) Error() string {
    return e.message
}

// In the erroringClient
func (e *erroringClient) List(ctx context.Context, list client.ObjectList, opts ...client.ListOption) error {
    return &MockError{message: "mocked list error"}
}

// In the test
It("should return an error", func() {
    namespaces, err := namespaceRepo.GetNamespaces(ctx)
    Expect(err).To(HaveOccurred())
    
    // Type assert to check for our specific error type
    var mockErr *MockError
    Expect(errors.As(err, &mockErr)).To(BeTrue())
    Expect(namespaces).To(BeNil())
})

Custom error types seem to be somewhat idiomatic in Go - and scales better if/when tests start becoming more complicated with need to test more side effects...

[roee1313]

got your point and learnt from it, thanks for that!

[andyatmiami]

/ok-to-test

[andyatmiami]

/lgtm

Verified running the make test command successfully executes the added tests

➜ backend/ git:((HEAD detached at roee/test_coverage_roee)) $ gmake test
go fmt ./...
go vet ./...
KUBEBUILDER_ASSETS="/Users/astonebe/Development/Code/GitHub/kubeflow-notebooks/workspaces/backend/bin/k8s/1.31.0-darwin-arm64" go test ./... -coverprofile cover.out
...
ok  	github.com/kubeflow/notebooks/workspaces/backend/internal/repositories/namespaces	0.625s	coverage: 100.0% of statements