-
Notifications
You must be signed in to change notification settings - Fork 49
Basic blueprints tests #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipped for now, because the default ember project generated doesn't have a `router.coffee`.
Skipping for now, because there's no system for generating the `router.coffee` file.
This one is so basic that we might just remove it - we just want to make sure that templates are generated even when the coffee blueprints are being used, and that happens just fine through the other blueprint tests.
The view-test blueprint tests are not passing for these and I'm not sure why, so they are skipped for now.
Closed
The upstream implementation doesn't use the newer separation of qunit and mocha test file structures, so the imported blueprint implementation didn't find the files where it expected to. I renamed the file to where the ember-legacy-blueprints view-test blueprint expected to find it.
- Install phantomjs differently - Cache different caches
I'm setting $NODE_TESTS to a specific value and checking for that instead of digging in to how to check for existence so that I can move on.
322b637 to
fefdaba
Compare
This is done to skip irrelevant installations based on test type.
Heavily borrowed from the `ember-cli-legacy-blueprints` addon.
|
Merging this now so I can keep iterating separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over from #106
Fixes #101
These tests are extremely closely based on the ones found in the
ember-cli-legacy-blueprintstests, much like the templates themselves.To do
Improvements?