Skip to content

Conversation

@kimroen
Copy link
Owner

@kimroen kimroen commented Dec 11, 2016

Takes over from #106

Fixes #101

These tests are extremely closely based on the ones found in the ember-cli-legacy-blueprints tests, much like the templates themselves.

To do

  • Set up running on Travis
  • ~~~Make the route and resource tests run~~~
  • Figure out what to do with the view tests (they are failing)
  • ~~~Make a list of all the options that need testing per blueprint, and then write tests for those~~~
  • Describe how to run tests in README

Improvements?

Skipped for now, because the default ember project generated doesn't have a `router.coffee`.
Skipping for now, because there's no system for generating the `router.coffee` file.
This one is so basic that we might just remove it - we just want to make sure that templates are generated even when the coffee blueprints are being used, and that happens just fine through the other blueprint tests.
The view-test blueprint tests are not passing for these and I'm not sure why, so they are skipped for now.
@kimroen kimroen mentioned this pull request Dec 11, 2016
The upstream implementation doesn't use the newer separation of qunit and mocha test file structures, so the imported blueprint implementation didn't find the files where it expected to. I renamed the file to where the ember-legacy-blueprints view-test blueprint expected to find it.
- Install phantomjs differently
- Cache different caches
@kimroen kimroen self-assigned this Jan 31, 2017
I'm setting $NODE_TESTS to a specific value and checking for that instead of digging in to how to check for existence so that I can move on.
This is done to skip irrelevant installations based on test type.
Heavily borrowed from the `ember-cli-legacy-blueprints` addon.
@kimroen
Copy link
Owner Author

kimroen commented Feb 1, 2017

Merging this now so I can keep iterating separately.

@kimroen kimroen changed the title [WIP] Blueprints tests Basic blueprints tests Feb 1, 2017
@kimroen kimroen merged commit 4231a98 into master Feb 1, 2017
@kimroen kimroen deleted the blueprints-tests branch February 1, 2017 21:29
@kimroen kimroen mentioned this pull request Feb 1, 2017
kimroen added a commit that referenced this pull request Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up tests

1 participant