Skip to content

Conversation

@kimroen
Copy link
Owner

@kimroen kimroen commented Mar 22, 2016

Fixes #101

kimroen added 2 commits March 22, 2016 19:35
This should fial, but it doesn't. What.
@kimroen
Copy link
Owner Author

kimroen commented Mar 22, 2016

Added some tests where one of them should fail just to check that everything is all right, but then they both passed.

@trabus
Copy link

trabus commented Mar 23, 2016

You're using the wrong property to check the file, it should be contains, not contents:

files (array): Array of files to assert, represented by objects with file, exists, contains, or doesNotContain properties. Example object:

files: [
  {
    file: 'path-to-file.js', 
    contains: ['file contents to compare'], 
    doesNotContain: ['file contents that shouldn\'t be present'], 
    exists: true //default true
  }
]```

files: [
{
file: 'app/adapters/foo.coffee',
contents: [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be contains here

Thanks, @trabus!
@kimroen kimroen force-pushed the blueprint-testing branch from 6bde0b0 to adac898 Compare March 29, 2016 23:40
@kimroen kimroen mentioned this pull request Dec 11, 2016
7 tasks
@kimroen
Copy link
Owner Author

kimroen commented Dec 11, 2016

I came back to take a look at this today, but so much had happened with the blueprint test helpers that I figured it would be better to start over. I did that over here: #129

Thanks for the help!

@kimroen kimroen closed this Dec 11, 2016
@kimroen kimroen deleted the blueprint-testing branch December 11, 2016 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants