libbpf: bpf__find_by_name[_kind] should use btf__get_nr_types() #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: 024cd2c |
When operating on split BTF, btf__find_by_name[_kind] will not iterate over all types since they use btf->nr_types to show the number of types to iterate over. For split BTF this is the number of types _on top of base BTF_, so it will underestimate the number of types to iterate over, especially for vmlinux + module BTF, where the latter is much smaller. Use btf__get_nr_types() instead. Fixes: ba45136 ("libbpf: Implement basic split BTF support") Signed-off-by: Alan Maguire <[email protected]>
|
Master branch: b93ef08 |
kernel-patches-bot
force-pushed
the
series/384395=>bpf-next
branch
from
4b599e0 to
63cb8e2
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=384395 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: bpf__find_by_name[_kind] should use btf__get_nr_types()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=384395