Use Tuple instead of Vector in test_quicktypes.jl #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## nomut #39 +/- ##
=====================================
Coverage 97.5% 97.5%
=====================================
Files 4 4
Lines 160 160
=====================================
Hits 156 156
Misses 4 4Continue to review full report at Codecov.
|
This was referenced Aug 14, 2018
Merged
This was referenced Aug 15, 2018
Closed
jw3126
pushed a commit
that referenced
this pull request
Aug 15, 2018
* Test against Julia 1.0 * Use the default test script * Fix after_success for Julia 1.0 * Enable tests with QuickTypes * Use Tuple instead of Vector in test_quicktypes.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not support
IndexLensfor mutable arrays, I think this is the way to go.