Test against Julia 1.0 #35
Conversation
.travis.yml
Outdated
| julia: | ||
| - 0.7 | ||
| - '0.7' | ||
| - '1.0' |
There was a problem hiding this comment.
Note that I have to do - '1.0' instead of - 1.0 since the latter would be interpreted as a float by the YAML parser. I changed 0.7 too for symmetry :)
Codecov Report
@@ Coverage Diff @@
## nomut #35 +/- ##
=====================================
Coverage 97.5% 97.5%
=====================================
Files 4 4
Lines 160 160
=====================================
Hits 156 156
Misses 4 4Continue to review full report at Codecov.
|
|
|
||
| # uncomment the following lines to override the default test script | ||
| script: | ||
| - julia -e 'Pkg.clone(pwd()); Pkg.build("Setfield"); VERSION < v"0.7-" && Pkg.add("StaticArrays"); Pkg.test("Setfield"; coverage=true)' |
There was a problem hiding this comment.
So for Julia 1.0 we need to remove this since Pkg is not imported by default anymore. Besides, we don't need to manually install it since we already have it in test/REQUIRE.
| language: julia | ||
| os: | ||
| - linux | ||
| - osx |
There was a problem hiding this comment.
Also, why not stop testing against macOS to increase CI throughput? Setfield.jl is a pure Julia package so shouldn't it behave identically across all OSes (unless Julia has some very specific bugs)?
|
closed by #39 |
2 participants
I checked it locally that it works. So I think it makes sense to have it in the CI.
It's a PR to #34.