Allow more contents manager functions to return futures #4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
changed the title
This allows slower contents managers to not block the event loop by allowing more of their API to return futures. Other usages of contents manager functions are already wrapped in maybe_future, including a use of `file_exists` in contents/handlers.py
michalc
changed the title
Member
|
Thanks! |
This was referenced Sep 24, 2019
michalc
added a commit
to michalc/notebook
that referenced
this pull request
Nov 24, 2019
This is a follow up to jupyter#4099
michalc
added a commit
to michalc/notebook
that referenced
this pull request
Nov 24, 2019
This is a follow up to jupyter#4099, wrapping another user of contents manager get with `maybe_future` to allow it to yield the event loop.
michalc
added a commit
to michalc/notebook
that referenced
this pull request
Nov 24, 2019
This is a follow up to jupyter#4099, wrapping other uses of contents manager get with `maybe_future` to allow it to yield the event loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows slower contents managers to not block the event loop by allowing more of their API to return futures.
Other usages of contents manager functions are already wrapped in maybe_future, including a use of
file_existsin contents/handlers.py