[Batch 3] Porting Notebook PRs #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently I needed to troubleshoot kernel responses and found it helpful to distinguish status types (busy vs. idle) - thought others might find it useful as well. Entries that previously appeared as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status ``` will now appear as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) ```
This allows slower contents managers to not block the event loop by allowing more of their API to return futures. Other usages of contents manager functions are already wrapped in maybe_future, including a use of `file_exists` in contents/handlers.py
Currently the default URL message given on the console on startup is:
---
Copy/paste this URL into your browser when you connect for the first time,
to login with a token:
http://(myip.com or 127.0.0.1):8888/?token=8fdc8 ...
---
This will always need editing to use. Replace with host IP (e.g. 'myip.com')
to make it copy/pastable again.
Currently the default URL message given on the console on startup is:
---
Copy/paste this URL into your browser when you connect for the first time,
to login with a token:
http://(myip.com or 127.0.0.1):8888/?token=8fdc8 ...
---
This will always need editing to use. Replace with one host IP (e.g. 'myip.com')
option and one local ip (127.0.0.1) option to make it copy/pastable again.
kevin-bates
reviewed
Sep 25, 2019
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
These changes look good, but I believe we have an issue introduced in batch-2 where the prometheus tests are failing due to an import reference. Let's patch those files prior to merging this.
kevin-bates
approved these changes
Sep 25, 2019
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Looks good - thanks for the quick updates.
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add config for deployment * Bump to 0.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue 96 before merging.
allow_remote_accesswhen ip is '*' jupyter/notebook#4139