Skip to content

improved color contrast for file menus #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2018
Merged

improved color contrast for file menus #4084

merged 2 commits into from
Dec 3, 2018

Conversation

@bhansa
Copy link

@bhansa bhansa commented Oct 9, 2018 •
edited
Loading

Udpdated the navbar background color and navbar link color Fixes #4000

@bhansa
Copy link
Author

bhansa commented Oct 9, 2018

please review
cc: @willingc

minrk
minrk reviewed Oct 10, 2018
View reviewed changes
@bhansa
Copy link
Author

bhansa commented Oct 27, 2018

Any update on this one?

@bhansa
Copy link
Author

bhansa commented Nov 25, 2018

cc: @minrk

@minrk
Copy link
Member

minrk commented Dec 3, 2018

Thanks!

@minrk minrk merged commit 82782a3 into jupyter:master Dec 3, 2018
@bhansa bhansa deleted the issues-4000-accessibility branch December 3, 2018 13:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@minrk minrk minrk left review comments

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A11y_AzureNotebooks_Jupyter_MenuBar_WAT: Color Contrast is less than 4.5:1 for Menus(File, Edit, View....etc).

3 participants

@bhansa @minrk @bsaraswat